linux-kernel - Re: [PATCH] checkpatch.pl: Allow '+' in compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200715072242.GA321038@ulmo>
Date:   Wed, 15 Jul 2020 09:22:42 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: Allow '+' in compatible strings

On Tue, Jul 14, 2020 at 11:42:15AM -0600, Rob Herring wrote:
> On Tue, Jul 14, 2020 at 11:12 AM Joe Perches <joe@...ches.com> wrote:
> >
> > On Tue, 2020-07-14 at 10:21 -0600, Rob Herring wrote:
> > > On Tue, Jul 14, 2020 at 3:41 AM Thierry Reding <thierry.reding@...il.com> wrote:
> > > > From: Thierry Reding <treding@...dia.com>
> > > >
> > > > The current checks will interpret a '+' character as special because
> > > > they use regular expression matching. Escape the '+' character if it
> > > > appears in a compatible string.
> > >
> > > Ugg, looks like c6x really liked using '+'. Might need to be added in
> > > schema checks, too. Not sure offhand.
> >
> > These are the non alphanumeric characters used in .dts and .dtsi files
> > with 'compatible=' strings
> >
> > - 44115
> > , 32035
> > . 1131
> > _ 259
> > + 46
> > / 18
> > ) 5
> > ( 5
> >
> > So it looks like
> >
> >         "("
> >         ")"
> >
> > need to be added and escaped too
> >
> > ?
> 
> No, those are 'regulator-compatible' AFAICT which is something else
> and deprecated.

Looks like we do need to escape the '.' character as well, although it
should be mostly harmless if we don't since '.' in the regex would also
match a literal '.' in the compatible string.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)