linux-kernel - Re: [PATCH] leds: add NCT6795D driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFuKomLcAue9rGXhK3Uc=H+v9ZLBA84Ozr_rZDRQMYeC=dg@mail.gmail.com>
Date:   Wed, 15 Jul 2020 10:54:00 +0900
From:   Alexandre Courbot <gnurou@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: add NCT6795D driver

Hi Pavel,

On Wed, Jul 15, 2020 at 7:33 AM Pavel Machek <pavel@....cz> wrote:
>
> Hi!
>
> > Add support for the LED feature of the NCT6795D chip found on some
> > motherboards, notably MSI ones. The LEDs are typically used using a
> > RGB connector so this driver creates one LED device for each color
> > component.
>
> Ok, let me take a look. What entries does it present in /sys?

Right now these 3 directories in /sys/class/leds:

nct6795d:blue:
nct6795d:green:
nct6795d:red:

with the usual suspects `brightness` and `max_brightness` in each. I
am not 100% sure I got the names right so please let me know if that
is not correct.

>
> We'll want you to switch to multicolor framework.

Most definitely. Last time I checked it was not merged yet though?

>
> > Also add self as maintainer.
>
> That will need to be separate patch, I'd be asking for trouble if I
> took that.

Note that I am also comfortable if you prefer to take care of this,
just didn't want to look like I was throwing this code at you without
following up on its maintenance.

Cheers,
Alex.