linux-kernel - Re: [PATCH RESEND 1/3] usb: gadget: udc: atmel: remove outdated comment in usba_ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9616d73d-d55c-1a33-58a0-6f36ba949f1c@microchip.com>
Date:   Thu, 16 Jul 2020 17:55:47 +0000
From:   <Cristian.Birsan@...rochip.com>
To:     <alexandre.belloni@...tlin.com>, <mirq-linux@...e.qmqm.pl>
CC:     <balbi@...nel.org>, <gregkh@...uxfoundation.org>,
        <Ludovic.Desroches@...rochip.com>, <Nicolas.Ferre@...rochip.com>,
        <songjun.wu@...el.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH RESEND 1/3] usb: gadget: udc: atmel: remove outdated
 comment in usba_ep_disable()



On 7/16/20 12:44 AM, Alexandre Belloni wrote:
> 
> On 08/07/2020 20:04:09+0200, Michał Mirosław wrote:
>> Fixed commit removed the offending behaviour from the driver, but missed
>> the comment and associated test. Remove them now.
>>
>> Fixes: 38e58986e6fc ("usb: gadget: udc: atmel: don't disable enpdoints we don't own")
>> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Acked-by: Cristian Birsan <cristian.birsan@...rochip.com>

> 
>> ---
>>  drivers/usb/gadget/udc/atmel_usba_udc.c | 8 +-------
>>  1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
>> index d69f61ff0181..9153e220848d 100644
>> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
>> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
>> @@ -676,13 +676,7 @@ static int usba_ep_disable(struct usb_ep *_ep)
>>
>>       if (!ep->ep.desc) {
>>               spin_unlock_irqrestore(&udc->lock, flags);
>> -             /* REVISIT because this driver disables endpoints in
>> -              * reset_all_endpoints() before calling disconnect(),
>> -              * most gadget drivers would trigger this non-error ...
>> -              */
>> -             if (udc->gadget.speed != USB_SPEED_UNKNOWN)
>> -                     DBG(DBG_ERR, "ep_disable: %s not enabled\n",
>> -                                     ep->ep.name);
>> +             DBG(DBG_ERR, "ep_disable: %s not enabled\n", ep->ep.name);
>>               return -EINVAL;
>>       }
>>       ep->ep.desc = NULL;
>> --
>> 2.20.1
>>
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>