linux-kernel - Re: [PATCH RESEND 2/3] usb: gadget: udc: atmel: fix uninitialized read in debug printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38c65e57-628e-f497-9538-50f6f5a9df04@microchip.com>
Date:   Thu, 16 Jul 2020 17:56:17 +0000
From:   <Cristian.Birsan@...rochip.com>
To:     <alexandre.belloni@...tlin.com>, <mirq-linux@...e.qmqm.pl>
CC:     <balbi@...nel.org>, <gregkh@...uxfoundation.org>,
        <Ludovic.Desroches@...rochip.com>, <Nicolas.Ferre@...rochip.com>,
        <songjun.wu@...el.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH RESEND 2/3] usb: gadget: udc: atmel: fix uninitialized
 read in debug printk



On 7/16/20 12:45 AM, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 08/07/2020 20:04:09+0200, Michał Mirosław wrote:
>> Fixed commit moved the assignment of 'req', but did not update a
>> reference in the DBG() call. Use the argument as it was renamed.
>>
>> Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module")
>> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Acked-by: Cristian Birsan <cristian.birsan@...rochip.com>

> 
>> ---
>>  drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
>> index 9153e220848d..9342a3d24963 100644
>> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
>> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
>> @@ -865,7 +865,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
>>       u32 status;
>>
>>       DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n",
>> -                     ep->ep.name, req);
>> +                     ep->ep.name, _req);
>>
>>       spin_lock_irqsave(&udc->lock, flags);
>>
>> --
>> 2.20.1
>>
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>