linux-kernel - Re: [PATCH 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd7f06a4-2c41-2f4d-309b-c30bb8d1c389@xilinx.com>
Date:   Thu, 16 Jul 2020 09:19:27 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Lee Jones <lee.jones@...aro.org>, broonie@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, Michal Simek <michal.simek@...inx.com>,
        Sureshkumar Relli <nagasure@...inx.com>
Subject: Re: [PATCH 09/14] spi: spi-zynq-qspi: Add description for 2 missing
 attributes/parameters



On 15. 07. 20 17:06, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi'
>  drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op'
>  drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op'
> 
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: Sureshkumar Relli <nagasure@...inx.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/spi/spi-zynq-qspi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c
> index bbf3d90561f54..5d8a5ee62fa23 100644
> --- a/drivers/spi/spi-zynq-qspi.c
> +++ b/drivers/spi/spi-zynq-qspi.c
> @@ -119,6 +119,7 @@
>  
>  /**
>   * struct zynq_qspi - Defines qspi driver instance
> + * @dev:		Pointer to the this device's information
>   * @regs:		Virtual address of the QSPI controller registers
>   * @refclk:		Pointer to the peripheral clock
>   * @pclk:		Pointer to the APB clock
> @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert)
>  /**
>   * zynq_qspi_config_op - Configure QSPI controller for specified transfer
>   * @xqspi:	Pointer to the zynq_qspi structure
> - * @qspi:	Pointer to the spi_device structure
> + * @spi:	Pointer to the spi_device structure
>   *
>   * Sets the operational mode of QSPI controller for the next QSPI transfer and
>   * sets the requested clock frequency.
> 

Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal