linux-kernel - Re: [PATCH 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74e6a09e-cbef-b727-aab9-e6c020a7dd6c@xilinx.com>
Date:   Thu, 16 Jul 2020 09:20:42 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Lee Jones <lee.jones@...aro.org>, broonie@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH 10/14] spi: spi-zynqmp-gqspi: Correct a couple of
 misspellings in kerneldoc



On 15. 07. 20 17:06, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavecs' not described in 'zynqmp_gqspi_selectslave'
>  drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavebus' not described in 'zynqmp_gqspi_selectslave'
>  drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashcs' description in 'zynqmp_gqspi_selectslave'
>  drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashbus' description in 'zynqmp_gqspi_selectslave'
>  drivers/spi/spi-zynqmp-gqspi.c:902: warning: Function parameter or member 'dev' not described in 'zynqmp_qspi_suspend'
>  drivers/spi/spi-zynqmp-gqspi.c:902: warning: Excess function parameter '_dev' description in 'zynqmp_qspi_suspend'
> 
> Cc: Michal Simek <michal.simek@...inx.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/spi/spi-zynqmp-gqspi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index 811c97a7c8589..e17a201252557 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -197,8 +197,8 @@ static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 offset,
>  /**
>   * zynqmp_gqspi_selectslave:	For selection of slave device
>   * @instanceptr:	Pointer to the zynqmp_qspi structure
> - * @flashcs:	For chip select
> - * @flashbus:	To check which bus is selected- upper or lower
> + * @slavecs:	For chip select
> + * @slavebus:	To check which bus is selected- upper or lower
>   */
>  static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
>  				     u8 slavecs, u8 slavebus)
> @@ -892,7 +892,7 @@ static int zynqmp_qspi_start_transfer(struct spi_master *master,
>  
>  /**
>   * zynqmp_qspi_suspend:	Suspend method for the QSPI driver
> - * @_dev:	Address of the platform_device structure
> + * @dev:	Address of the platform_device structure
>   *
>   * This function stops the QSPI driver queue and disables the QSPI controller
>   *
> 

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal