linux-kernel - Re: [PATCH v4 1/8] irqchip/loongson-htpic: Remove redundant kfree operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a865581c-0566-f7c0-380b-488ccfe4205f@web.de>
Date:   Thu, 16 Jul 2020 10:45:34 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>, linux-mips@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Huacai Chen <chenhc@...ote.com>,
        Jason Cooper <jason@...edaemon.net>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Marc Zyngier <maz@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v4 1/8] irqchip/loongson-htpic: Remove redundant kfree
 operation

> In the function htpic_of_init(), when kzalloc htpic fails, it should
> return -ENOMEM directly, no need to execute "goto" to kfree.

Would another imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f8456690ba8eb18ea4714e68554e242a04f65cff#n151

Regards,
Markus