linux-kernel - Re: [PATCHv2] mm: Fix warning in move_normal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200716084651.4457czjaszv3uprv@box>
Date:   Thu, 16 Jul 2020 11:46:51 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux-MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        William Kucharski <william.kucharski@...cle.com>
Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd()

On Thu, Jul 16, 2020 at 12:53:23PM +0530, Naresh Kamboju wrote:
> On Thu, 16 Jul 2020 at 12:07, Naresh Kamboju <naresh.kamboju@...aro.org> wrote:
> >
> > On Thu, 16 Jul 2020 at 04:49, Linus Torvalds
> > <torvalds@...ux-foundation.org> wrote:
> > >
> > > On Wed, Jul 15, 2020 at 4:04 PM Linus Torvalds
> > > <torvalds@...ux-foundation.org> wrote:
> > > >
> > > > It *might* be as simple as this incremental thing on top
> > >
> > > No, it needs to be
> > >
> > > +       if (*old_addr + *len < old->vm_end)
> > > +               return;
> > >
> > > in try_to_align_end(), of course.
> > >
> > > Now I'm going for a lie-down, because this cross-eyed thing isn't working.
> >
> >
> > Just want to double check.
> > Here is the diff after those two patches applied. Please correct me if
> > it is wrong.
> > This patch applied on top of Linus mainline master branch.
> > I am starting my test cycles.
> 
> Sorry this patch (the below pasted ) did not solve the reported problem.

As Linus said, it does not trigger on the stack movement anymore and it is
not going to fix the issue, but may help to increase coverage of the
optimization.

-- 
 Kirill A. Shutemov