linux-kernel - Re: [PATCH 2/2] kvm: mmu: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Jul 2020 00:35:12 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     "Paul E. McKenney" <paulmck@...nel.org>,
        madhuparnabhowmik10@...il.com
Cc:     Dexuan-Linux Cui <dexuan.linux@...il.com>,
        Josh Triplett <josh@...htriplett.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Paolo Bonzini <pbonzini@...hat.com>, rcu@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        X86 ML <x86@...nel.org>, kvm list <kvm@...r.kernel.org>,
        frextrite@...il.com, lkft-triage@...ts.linaro.org,
        Dexuan Cui <decui@...rosoft.com>, juhlee@...rosoft.com,
        Daniel Díaz <daniel.diaz@...aro.org>
Subject: Re: [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage

Hi Paul,

> I am not seeing this here.

Do you notice any warnings while building linux next master
for x86_64 architecture ?

> Could you please let us know what compiler
> and command-line options you are using to generate this?

We have two build systems one showing it as error and build breaks
and another one showing it as warning and build pass.
tool chain: gcc 9.3.0
build command:
make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=x86 HOSTCC=gcc
CC="sccache gcc" O=build

metadata:
    git_repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git,
    target_arch: x86,
    toolchain: gcc-9,
    git_short_log: aab7ee9f8ff0 (\Add linux-next specific files for 20200717\),
    git_sha: aab7ee9f8ff0110bfcd594b33dc33748dc1baf46,
    git_describe: next-20200717,
    kernel_version: 5.8.0-rc5,

warning log,
--
make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=x86 HOSTCC=gcc
CC="sccache gcc" O=build
#
In file included from ../include/linux/pid.h:5,
                 from ../include/linux/sched.h:14,
                 from ../include/linux/kvm_host.h:12,
                 from ../arch/x86/kvm/mmu/page_track.c:14:
../arch/x86/kvm/mmu/page_track.c: In function ‘kvm_page_track_write’:
../include/linux/rculist.h:727:30: warning: left-hand operand of comma
expression has no effect [-Wunused-value]
  727 |  for (__list_check_srcu(cond),     \
      |                              ^
../arch/x86/kvm/mmu/page_track.c:232:2: note: in expansion of macro
‘hlist_for_each_entry_srcu’
  232 |  hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
../arch/x86/kvm/mmu/page_track.c: In function ‘kvm_page_track_flush_slot’:
../include/linux/rculist.h:727:30: warning: left-hand operand of comma
expression has no effect [-Wunused-value]
  727 |  for (__list_check_srcu(cond),     \
      |                              ^
../arch/x86/kvm/mmu/page_track.c:258:2: note: in expansion of macro
‘hlist_for_each_entry_srcu’
  258 |  hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kvm/svm/svm.o: warning: objtool: svm_flush_tlb_gva()+0x12:
call without frame pointer save/setup
kernel/bpf/core.o: warning: objtool: ___bpf_prog_run.cold()+0x7: call
without frame pointer save/setup

ref:
https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/643978120


>                                                         Thanx, Paul

- Naresh