linux-kernel - Re: [PATCH 2/2] kvm: mmu: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200718001259.GY9247@paulmck-ThinkPad-P72>
Date:   Fri, 17 Jul 2020 17:12:59 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     madhuparnabhowmik10@...il.com,
        Dexuan-Linux Cui <dexuan.linux@...il.com>,
        Josh Triplett <josh@...htriplett.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Paolo Bonzini <pbonzini@...hat.com>, rcu@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        X86 ML <x86@...nel.org>, kvm list <kvm@...r.kernel.org>,
        frextrite@...il.com, lkft-triage@...ts.linaro.org,
        Dexuan Cui <decui@...rosoft.com>, juhlee@...rosoft.com,
        Daniel Díaz <daniel.diaz@...aro.org>
Subject: Re: [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage

On Sat, Jul 18, 2020 at 12:35:12AM +0530, Naresh Kamboju wrote:
> Hi Paul,
> 
> > I am not seeing this here.
> 
> Do you notice any warnings while building linux next master
> for x86_64 architecture ?

Idiot here was failing to enable building of KVM.  With that, I do see
the error.  The patch resolves it for me.  Does it help for you?

							Thanx, Paul

------------------------------------------------------------------------

diff --git a/include/linux/rculist.h b/include/linux/rculist.h
index de9385b..f8633d3 100644
--- a/include/linux/rculist.h
+++ b/include/linux/rculist.h
@@ -73,7 +73,7 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head *list)
 #define __list_check_rcu(dummy, cond, extra...)				\
 	({ check_arg_count_one(extra); })
 
-#define __list_check_srcu(cond) true
+#define __list_check_srcu(cond) ({ })
 #endif
 
 /*