linux-kernel - Re: [PATCH v2] pwm: bcm-iproc: handle clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200717230431.4oj44cfnkhkd2o6z@pengutronix.de>
Date:   Sat, 18 Jul 2020 01:04:31 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Scott Branden <scott.branden@...adcom.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
Subject: Re: [PATCH v2] pwm: bcm-iproc: handle clk_get_rate() return

On Fri, Jul 17, 2020 at 11:25:12AM -0700, Scott Branden wrote:
> From: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
> 
> Handle clk_get_rate() returning <= 0 condition to avoid
> possible division by zero.

You advertise handling <= 0, but in the code only == 0 is checked. One
of the two is wrong ...

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)