linux-kernel - Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200719100522.220a6f5a@hermes.lan>
Date:   Sun, 19 Jul 2020 10:05:22 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Bixuan Cui <cuibixuan@...wei.com>
Cc:     <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <jdmason@...zu.us>,
        <christophe.jaillet@...adoo.fr>, <john.wanghui@...wei.com>
Subject: Re: [PATCH] net: neterion: vxge: reduce stack usage in
 VXGE_COMPLETE_VPATH_TX

On Thu, 16 Jul 2020 17:32:47 +0000
Bixuan Cui <cuibixuan@...wei.com> wrote:

> Fix the warning: [-Werror=-Wframe-larger-than=]
> 
> drivers/net/ethernet/neterion/vxge/vxge-main.c:
> In function'VXGE_COMPLETE_VPATH_TX.isra.37':
> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
> warning: the frame size of 1056 bytes is larger than 1024 bytes
> 
> Signed-off-by: Bixuan Cui <cuibixuan@...wei.com>

Dropping the NR_SKB_COMPLETED to 16 won't have much impact
on performance, and shrink the size.

Doing 16 skb's at a time instead of 128 probably costs
less than one allocation. Especially since it is unlikely
that the device completed that many transmits at once.