lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Jul 2020 12:05:45 -0500 From: "Serge E. Hallyn" <serge@...lyn.com> To: Adrian Reber <areber@...hat.com> Cc: Christian Brauner <christian.brauner@...ntu.com>, Eric Biederman <ebiederm@...ssion.com>, Pavel Emelyanov <ovzxemul@...il.com>, Oleg Nesterov <oleg@...hat.com>, Dmitry Safonov <0x7f454c46@...il.com>, Andrei Vagin <avagin@...il.com>, Nicolas Viennot <Nicolas.Viennot@...sigma.com>, Michał Cłapiński <mclapinski@...gle.com>, Kamil Yurtsever <kyurtsever@...gle.com>, Dirk Petersen <dipeit@...il.com>, Christine Flood <chf@...hat.com>, Casey Schaufler <casey@...aufler-ca.com>, Mike Rapoport <rppt@...ux.ibm.com>, Radostin Stoyanov <rstoyanov1@...il.com>, Cyrill Gorcunov <gorcunov@...nvz.org>, Serge Hallyn <serge@...lyn.com>, Stephen Smalley <stephen.smalley.work@...il.com>, Sargun Dhillon <sargun@...gun.me>, Arnd Bergmann <arnd@...db.de>, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, selinux@...r.kernel.org, Eric Paris <eparis@...isplace.org>, Jann Horn <jannh@...gle.com>, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH v6 6/7] prctl: exe link permission error changed from -EINVAL to -EPERM On Sun, Jul 19, 2020 at 12:04:16PM +0200, Adrian Reber wrote: > From: Nicolas Viennot <Nicolas.Viennot@...sigma.com> > > This brings consistency with the rest of the prctl() syscall where > -EPERM is returned when failing a capability check. > > Signed-off-by: Nicolas Viennot <Nicolas.Viennot@...sigma.com> > Signed-off-by: Adrian Reber <areber@...hat.com> Ok, i see how EINVAL snuck its way in there through validate_prctl_map()s evolution :) Reviewed-by: Serge Hallyn <serge@...lyn.com> > --- > kernel/sys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sys.c b/kernel/sys.c > index a3f4ef0bbda3..ca11af9d815d 100644 > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -2015,7 +2015,7 @@ static int prctl_set_mm_map(int opt, const void __user *addr, unsigned long data > * This may have implications in the tomoyo subsystem. > */ > if (!checkpoint_restore_ns_capable(current_user_ns())) > - return -EINVAL; > + return -EPERM; > > error = prctl_set_mm_exe_file(mm, prctl_map.exe_fd); > if (error) > -- > 2.26.2
Powered by blists - more mailing lists