linux-kernel - Re: [PATCH] dt-bindings: hwmon: adm1272: add adm1272-adm1275-temp1-en binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200719222222.GA78762@roeck-us.net>
Date:   Sun, 19 Jul 2020 15:22:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Chu Lin <linchuyuan@...gle.com>
Cc:     belgaied@...gle.com, jasonling@...gle.com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhongqil@...gle.com
Subject: Re: [PATCH] dt-bindings: hwmon: adm1272: add
 adm1272-adm1275-temp1-en binding

On Fri, Jul 10, 2020 at 12:42:58AM +0000, Chu Lin wrote:
> Problem:
> 	adm1272 and adm1278 supports temperature sampling. The
> current way of enabling it requires the user manually unbind the device
> from the driver, flip the temperature sampling control bit and then bind
> the device back to the driver. It would be nice if we can control this in a
> better way by reading the dt.
> 
> Solution:
> 	Introducing device tree binding adm1272-adm1278-temp1-en. If the
> flag is set, flip the temp1_en control bit on probing.
> 
> Testing:
> make dt_binding_check
> 
> Signed-off-by: Chu Lin <linchuyuan@...gle.com>
> ---
>  Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> index 1ecd03f3da4d..4403fe30f005 100644
> --- a/Documentation/devicetree/bindings/hwmon/adm1275.txt
> +++ b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> @@ -15,6 +15,8 @@ Optional properties:
>  
>  - shunt-resistor-micro-ohms
>  	Shunt resistor value in micro-Ohm
> +- adm1272-adm1278-temp1-en
> +	Enable temperature sampling. This is supported on adm1272 and adm1278

I suspect this should be something like "analog,temp1-enable". Either case,
I would suggest to resend the series and copy DT maintainers at least on
this patch.

Thanks,
Guenter

>  
>  Example:
>  
> @@ -22,4 +24,5 @@ adm1272@10 {
>  	compatible = "adi,adm1272";
>  	reg = <0x10>;
>  	shunt-resistor-micro-ohms = <500>;
> +	adm1272-adm1278-temp1-en;
>  };