linux-kernel - Re: [PATCH] dt-bindings: hwmon: adm1272: add adm1272-adm1275-temp1-en binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKCA56CSyG3+RvmEYPpv3VC8mnmTFopd-Ee-xzF62ie80g+cag@mail.gmail.com>
Date:   Sun, 19 Jul 2020 20:12:44 -0700
From:   Chu Lin <linchuyuan@...gle.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Kais Belgaied <belgaied@...gle.com>,
        Jason Ling <jasonling@...gle.com>, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zhongqi Li <zhongqil@...gle.com>
Subject: Re: [PATCH] dt-bindings: hwmon: adm1272: add adm1272-adm1275-temp1-en binding

On Sun, Jul 19, 2020 at 3:22 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Fri, Jul 10, 2020 at 12:42:58AM +0000, Chu Lin wrote:
> > Problem:
> >       adm1272 and adm1278 supports temperature sampling. The
> > current way of enabling it requires the user manually unbind the device
> > from the driver, flip the temperature sampling control bit and then bind
> > the device back to the driver. It would be nice if we can control this in a
> > better way by reading the dt.
> >
> > Solution:
> >       Introducing device tree binding adm1272-adm1278-temp1-en. If the
> > flag is set, flip the temp1_en control bit on probing.
> >
> > Testing:
> > make dt_binding_check
> >
> > Signed-off-by: Chu Lin <linchuyuan@...gle.com>
> > ---
> >  Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> > index 1ecd03f3da4d..4403fe30f005 100644
> > --- a/Documentation/devicetree/bindings/hwmon/adm1275.txt
> > +++ b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> > @@ -15,6 +15,8 @@ Optional properties:
> >
> >  - shunt-resistor-micro-ohms
> >       Shunt resistor value in micro-Ohm
> > +- adm1272-adm1278-temp1-en
> > +     Enable temperature sampling. This is supported on adm1272 and adm1278
>
> I suspect this should be something like "analog,temp1-enable". Either case,
> I would suggest to resend the series and copy DT maintainers at least on
> this patch.

Thanks for the heads up. I will send another review with a fix.

Thanks,
Chu