linux-kernel - Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fac7f266-98e5-2750-7230-d4e6bc94b4d4@ti.com>
Date:   Mon, 20 Jul 2020 09:19:32 -0400
From:   Murali Karicheri <m-karicheri2@...com>
To:     David Miller <davem@...emloft.net>
CC:     <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-api@...r.kernel.org>,
        <nsekhar@...com>, <grygorii.strashko@...com>,
        <vinicius.gomes@...el.com>
Subject: Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to
 support PRP



On 7/17/20 9:56 PM, David Miller wrote:
> From: Murali Karicheri <m-karicheri2@...com>
> Date: Fri, 17 Jul 2020 11:15:05 -0400
> 
>> @@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev,
>>   		       struct netlink_ext_ack *extack)
>>   {
>>   	struct net_device *link[2];
>> -	unsigned char multicast_spec, hsr_version;
>> +	unsigned char multicast_spec;
>> +	enum hsr_version proto_version;
>> +	u8 proto = HSR_PROTOCOL_HSR;
> 
> Please use reverse christmas tree ordering for local variables.
> 
Ok.
> Thank you.
> 

-- 
Murali Karicheri
Texas Instruments