linux-kernel - Re: [net-next PATCH v3 2/7] net: hsr: introduce common code for skb initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <013a7d42-d163-126f-aeac-5f72dfe29ad6@ti.com>
Date:   Mon, 20 Jul 2020 09:20:44 -0400
From:   Murali Karicheri <m-karicheri2@...com>
To:     David Miller <davem@...emloft.net>
CC:     <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-api@...r.kernel.org>,
        <nsekhar@...com>, <grygorii.strashko@...com>,
        <vinicius.gomes@...el.com>
Subject: Re: [net-next PATCH v3 2/7] net: hsr: introduce common code for skb
 initialization



On 7/17/20 9:56 PM, David Miller wrote:
> From: Murali Karicheri <m-karicheri2@...com>
> Date: Fri, 17 Jul 2020 11:15:06 -0400
> 
>> +static void send_hsr_supervision_frame(struct hsr_port *master,
>> +				       u8 type, u8 hsr_ver)
>> +{
>> +	struct sk_buff *skb;
>> +	struct hsr_tag *hsr_tag;
>> +	struct hsr_sup_tag *hsr_stag;
>> +	struct hsr_sup_payload *hsr_sp;
>> +	unsigned long irqflags;
> 
> Reverse christmas tree please.
> 
OK
-- 
Murali Karicheri
Texas Instruments