[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200720145202.GA621928@dell>
Date: Mon, 20 Jul 2020 15:52:02 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: ricky_wu@...ltek.com, Arnd Bergmann <arnd@...db.de>,
Greg KH <gregkh@...uxfoundation.org>,
Ulf Hansson <ulf.hansson@...aro.org>, rui_feng@...lsil.com.cn,
Bjorn Helgaas <bhelgaas@...gle.com>, kdlnx@...h.eu,
Rui Miguel Silva <rmfrfs@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] misc: rtsx: Add support new chip rts5228 mmc: rtsx: Add
support MMC_CAP2_NO_MMC
On Mon, 20 Jul 2020, Linus Walleij wrote:
> On Mon, Jul 6, 2020 at 9:03 AM <ricky_wu@...ltek.com> wrote:
>
> > drivers/misc/cardreader/Makefile | 2 +-
> > drivers/misc/cardreader/rts5228.c | 740 +++++++++++++++++++++++++++++
> > drivers/misc/cardreader/rts5228.h | 168 +++++++
> > drivers/misc/cardreader/rtsx_pcr.c | 89 ++--
> > drivers/misc/cardreader/rtsx_pcr.h | 5 +
>
> This drivers/misc/cardreader business is a big confusion for my mind.
>
> Is it really that fantastic that it needs to be a unique special case?
>
> To me it looks like a drivers/mfd thing which should have separate
> drivers/regulator/rts5228.c (LDOs)
> drivers/clk/rts5228.c (clocks)
> subdrivers.
>
> See for example drivers/mfd/sta2x11-mfd.c thay spawns a few
> devices off a PCI card.
Thanks for Cc'ing me Linus.
Can you please bounce the diff to me too?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists