linux-kernel - Re: [PATCH v2 4/7] usb: bdc: Adb shows offline after resuming from S2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <288342d0-4a6a-4780-855e-ae2844a9a0e5@gmail.com>
Date:   Tue, 21 Jul 2020 10:33:50 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Al Cooper <alcooperx@...il.com>, linux-kernel@...r.kernel.org
Cc:     devicetree@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Sasi Kumar <sasi.kumar@...adcom.com>
Subject: Re: [PATCH v2 4/7] usb: bdc: Adb shows offline after resuming from S2

On 7/21/20 7:43 AM, Al Cooper wrote:
> On Android systems, After temporarily putting device to S2 by
> short pressing the power button on the remote, the display turns
> off. Then press the power button to turn the display back up. Adb
> devices would show the devices is offline. It needs a physical
> disconnect of the usb cable or power cycle to bring the device
> back online. The device is operational otherwise.
> 
> The problem is that during S2 resume, the ADB gadget driver could
> not link back with the BDC driver because the endpoint flags were
> cleared. The fix is to clear the endpoint flags for the disconnect
> case only and not for S2 exit.
> 
> Signed-off-by: Al Cooper <alcooperx@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian