linux-kernel - Re: [PATCH 10/10] block: scsi: sr: use blk_is_valid_logical_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR04MB37517861074A4A448180E136E7780@CY4PR04MB3751.namprd04.prod.outlook.com>
Date:   Tue, 21 Jul 2020 11:29:48 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     Maxim Levitsky <mlevitsk@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Keith Busch <kbusch@...nel.org>,
        Josef Bacik <josef@...icpanda.com>,
        "open list:BLOCK LAYER" <linux-block@...r.kernel.org>,
        Sagi Grimberg <sagi@...mberg.me>, Jens Axboe <axboe@...nel.dk>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@...ts.infradead.org>,
        "open list:SCSI CDROM DRIVER" <linux-scsi@...r.kernel.org>,
        Tejun Heo <tj@...nel.org>,
        Bart Van Assche <bvanassche@....org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Jason Wang <jasowang@...hat.com>,
        Maxim Levitsky <maximlevitsky@...il.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Colin Ian King <colin.king@...onical.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Ajay Joshi <Ajay.Joshi@....com>,
        Ming Lei <ming.lei@...hat.com>,
        "open list:SONY MEMORYSTICK SUBSYSTEM" <linux-mmc@...r.kernel.org>,
        Christoph Hellwig <hch@....de>,
        Satya Tangirala <satyat@...gle.com>,
        "open list:NETWORK BLOCK DEVICE (NBD)" <nbd@...er.debian.org>,
        Hou Tao <houtao1@...wei.com>, Jens Axboe <axboe@...com>,
        "open list:VIRTIO CORE AND NET DRIVERS" 
        <virtualization@...ts.linux-foundation.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Alex Dubov <oakad@...oo.com>
Subject: Re: [PATCH 10/10] block: scsi: sr: use
 blk_is_valid_logical_block_size

On 2020/07/21 19:55, Maxim Levitsky wrote:
> Plus some tiny refactoring.
> 
> Signed-off-by: Maxim Levitsky <mlevitsk@...hat.com>
> ---
>  drivers/scsi/sr.c | 31 +++++++++++++------------------
>  1 file changed, 13 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
> index 0c4aa4665a2f9..0e96338029310 100644
> --- a/drivers/scsi/sr.c
> +++ b/drivers/scsi/sr.c
> @@ -866,31 +866,26 @@ static void get_sectorsize(struct scsi_cd *cd)
>  			cd->capacity = max_t(long, cd->capacity, last_written);
>  
>  		sector_size = get_unaligned_be32(&buffer[4]);
> -		switch (sector_size) {
> -			/*
> -			 * HP 4020i CD-Recorder reports 2340 byte sectors
> -			 * Philips CD-Writers report 2352 byte sectors
> -			 *
> -			 * Use 2k sectors for them..
> -			 */
> -		case 0:
> -		case 2340:
> -		case 2352:
> +
> +		/*
> +		 * HP 4020i CD-Recorder reports 2340 byte sectors
> +		 * Philips CD-Writers report 2352 byte sectors
> +		 *
> +		 * Use 2k sectors for them..
> +		 */
> +

No need for the blank line here.

> +		if (!sector_size || sector_size == 2340 || sector_size == 2352)
>  			sector_size = 2048;
> -			/* fall through */
> -		case 2048:
> -			cd->capacity *= 4;
> -			/* fall through */
> -		case 512:
> -			break;
> -		default:
> +
> +		cd->capacity *= (sector_size >> SECTOR_SHIFT);

Where does this come from ? There is no such code in sr get_sectorsize()...

> +
> +		if (!blk_is_valid_logical_block_size(sector_size)) {
>  			sr_printk(KERN_INFO, cd,
>  				  "unsupported sector size %d.", sector_size);
>  			cd->capacity = 0;
>  		}
>  
>  		cd->device->sector_size = sector_size;
> -

White line change.

>  		/*
>  		 * Add this so that we have the ability to correctly gauge
>  		 * what the device is capable of.
> 


-- 
Damien Le Moal
Western Digital Research