linux-kernel - Re: [PATCH] cxgb4: add missing release on skb in uld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200720.183113.2100585349998522874.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 18:31:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     navid.emamdoost@...il.com
Cc:     vishal@...lsio.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, emamd001@....edu
Subject: Re: [PATCH] cxgb4: add missing release on skb in uld_send()

From: Navid Emamdoost <navid.emamdoost@...il.com>
Date: Sat, 18 Jul 2020 00:18:43 -0500

> diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
> index 32a45dc51ed7..d8c37fd4b808 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
> @@ -2938,6 +2938,7 @@ static inline int uld_send(struct adapter *adap, struct sk_buff *skb,
>  	txq_info = adap->sge.uld_txq_info[tx_uld_type];
>  	if (unlikely(!txq_info)) {
>  		WARN_ON(true);
> +		consume_skb(skb);
>  		return NET_XMIT_DROP;
>  	}
>  

This is a packet drop so kfree_skb() is more appropriate here.