linux-kernel - Re: [PATCH] mISDN: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200720.183233.1523852489153157390.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 18:32:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     isdn@...ux-pingi.de, sergey.senozhatsky@...il.com,
        wangkefeng.wang@...wei.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mISDN: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sat, 18 Jul 2020 12:30:33 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
> 
> When memory is allocated in 'setup_hw()' (hfcpci.c) GFP_KERNEL can be used
> because it is called from the probe function and no lock is taken.
> The call chain is:
>    hfc_probe()
>    --> setup_card()
>    --> setup_hw()
> 
> When memory is allocated in 'inittiger()' (netjet.c) GFP_ATOMIC must be
> used because a spin_lock is taken by the caller (i.e. 'nj_init_card()')
> This is also consistent with the other allocations done in the function.
 ...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied, thanks.