[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200722003440.GB5807@b29397-desktop>
Date: Wed, 22 Jul 2020 00:34:49 +0000
From: Peter Chen <peter.chen@....com>
To: Pawel Laszczak <pawell@...ence.com>
CC: "balbi@...nel.org" <balbi@...nel.org>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"rogerq@...com" <rogerq@...com>,
"dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
"heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
"colin.king@...onical.com" <colin.king@...onical.com>,
"jpawar@...ence.com" <jpawar@...ence.com>,
"ben.dooks@...ethink.co.uk" <ben.dooks@...ethink.co.uk>,
"kurahul@...ence.com" <kurahul@...ence.com>,
"sparmar@...ence.com" <sparmar@...ence.com>
Subject: Re: [PATCH v2 3/9] usb: cnds3: drd: deleted !=
On 20-07-13 12:05:48, Pawel Laszczak wrote:
> Patch deletes unnecessary != from condition statement in cdns3_drd_init
> function.
>
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
Reviewed-by: Peter Chen <peter.chen@....com>
> ---
> drivers/usb/cdns3/drd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 4939a568d8a2..6d2da504ad49 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -365,7 +365,7 @@ int cdns3_drd_init(struct cdns3 *cdns)
> }
>
> state = readl(&cdns->otg_regs->sts);
> - if (OTGSTS_OTG_NRDY(state) != 0) {
> + if (OTGSTS_OTG_NRDY(state)) {
> dev_err(cdns->dev, "Cadence USB3 OTG device not ready\n");
> return -ENODEV;
> }
> --
> 2.17.1
>
--
Thanks,
Peter Chen
Powered by blists - more mailing lists