linux-kernel - Re: [PATCH v2 4/9] usb: cdns3: drd: return IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200722003509.GC5807@b29397-desktop>
Date:   Wed, 22 Jul 2020 00:35:19 +0000
From:   Peter Chen <peter.chen@....com>
To:     Pawel Laszczak <pawell@...ence.com>
CC:     "balbi@...nel.org" <balbi@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rogerq@...com" <rogerq@...com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "jpawar@...ence.com" <jpawar@...ence.com>,
        "ben.dooks@...ethink.co.uk" <ben.dooks@...ethink.co.uk>,
        "kurahul@...ence.com" <kurahul@...ence.com>,
        "sparmar@...ence.com" <sparmar@...ence.com>
Subject: Re: [PATCH v2 4/9] usb: cdns3: drd: return IRQ_NONE explicitly.

On 20-07-13 12:05:49, Pawel Laszczak wrote:
> IRQ_NONE can be returned indirect.
> 
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>

Reviewed-by: Peter Chen <peter.chen@....com>

> ---
>  drivers/usb/cdns3/drd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 6d2da504ad49..05a9f7d54c46 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -279,12 +279,12 @@ static irqreturn_t cdns3_drd_irq(int irq, void *data)
>  	u32 reg;
>  
>  	if (cdns->dr_mode != USB_DR_MODE_OTG)
> -		return ret;
> +		return IRQ_NONE;
>  
>  	reg = readl(&cdns->otg_regs->ivect);
>  
>  	if (!reg)
> -		return ret;
> +		return IRQ_NONE;
>  
>  	if (reg & OTGIEN_ID_CHANGE_INT) {
>  		dev_dbg(cdns->dev, "OTG IRQ: new ID: %d\n",
> -- 
> 2.17.1
> 

-- 

Thanks,
Peter Chen