linux-kernel - Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59d0a02c-cfae-1170-728d-2ae332a81f6e@ti.com>
Date:   Tue, 21 Jul 2020 19:05:13 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <jacek.anaszewski@...il.com>, <robh@...nel.org>,
        <marek.behun@....cz>, <devicetree@...r.kernel.org>,
        <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB
 LED driver

Pavel

On 7/21/20 4:07 PM, Pavel Machek wrote:
> On Thu 2020-07-16 13:19:58, Dan Murphy wrote:
>> Introduce the LP5036/30/24/18/12/9 RGB LED driver.
>> The difference in these parts are the number of
>> LED outputs where the:
>>
>> LP5036 can control 36 LEDs
>> LP5030 can control 30 LEDs
>> LP5024 can control 24 LEDs
>> LP5018 can control 18 LEDs
>> LP5012 can control 12 LEDs
>> LP5009 can control 9 LEDs
>>
>> The device has the ability to group LED output into control banks
>> so that multiple LED banks can be controlled with the same mixing and
>> brightness.  Inversely the LEDs can also be controlled independently.
>>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> +/*
>> + * struct lp50xx_chip_info -
>> + * @num_leds: number of LED outputs available on the device
>> + * @led_brightness0_reg: first brightness register of the device
>> + * @mix_out0_reg: first color mix register of the device
>> + * @bank_brt_reg: bank brightness register
>> + * @bank_mix_reg: color mix register
>> + * @reset_reg: device reset register
>> + */
> Should have /** if this is kerneldoc.
>
>> +		init_data.fwnode = child;
>> +		num_colors = 0;
>> +
>> +		/* There are only 3 LEDs per module otherwise they should be
>> +		 * banked which also is presented as 3 LEDs
>> +		 */
> This is not usual comment style for kernel. (And add . at end of
> sentence).

I will fix both.

Dan


> Best regards,
> 									Pavel