linux-kernel - Re: [PATCH v1 1/2] {topost} scsi: libsas: delete postreset at sas_sata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53b95bb4-c129-beff-9bc6-02225db2e762@huawei.com>
Date:   Wed, 22 Jul 2020 18:27:04 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Luo Jiaxing <luojiaxing@...wei.com>, <martin.petersen@...cle.com>,
        <jejb@...ux.ibm.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <john.garry@...wei.com>, <chenxiang66@...ilicon.com>,
        <linuxarm@...wei.com>
Subject: Re: [PATCH v1 1/2] {topost} scsi: libsas: delete postreset at
 sas_sata_ops


在 2020/7/22 17:04, Luo Jiaxing 写道:
> We fill postreset with ata_std_postreset() at sas_sata_ops before, but we
> found out that ata_std_postreset() call sata_scr_read()/sata_scr_write()
> which need to access SCR register. Actually we don't own these kind of
> register, so sata_scr_read()/sata_scr_write always return -EOPNOTSUPP.
> 
> We drop ata_std_postreset() at sas_sata_ops.
> 
> Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>
> Reviewed-by: John Garry <john.garry@...wei.com>
> ---
>   drivers/scsi/libsas/sas_ata.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 5d716d3..a7d16d2 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -510,7 +510,6 @@ void sas_ata_end_eh(struct ata_port *ap)
>   static struct ata_port_operations sas_sata_ops = {
>   	.prereset		= ata_std_prereset,
>   	.hardreset		= sas_ata_hard_reset,
> -	.postreset		= ata_std_postreset,
>   	.error_handler		= ata_std_error_handler,
>   	.post_internal_cmd	= sas_ata_post_internal,
>   	.qc_defer               = ata_std_qc_defer,
> 

Hi Luo,

Please remove the "{topost}" in the subject, other than that:

Reviewed-by: Jason Yan <yanaijie@...wei.com>