[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1658a661-bf58-85b6-8475-7c29dce63eb3@huawei.com>
Date: Wed, 22 Jul 2020 18:31:30 +0800
From: Jason Yan <yanaijie@...wei.com>
To: Luo Jiaxing <luojiaxing@...wei.com>, <martin.petersen@...cle.com>,
<jejb@...ux.ibm.com>
CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<john.garry@...wei.com>, <chenxiang66@...ilicon.com>,
<linuxarm@...wei.com>
Subject: Re: [PATCH v1 2/2] {topost} scsi: libsas: check link status at ATA
prereset() ops
在 2020/7/22 17:04, Luo Jiaxing 写道:
> We found out that libata will retry reset even if SATA disk is unpluged. We
> should report offline to libata to avoid meaningless reset on the disk.
> Libata provide an ops of prereset() for this purpose, it was called by
> ata_eh_reset() only and used to decide whether to skip reset base on the
> return value of it.
>
> We check status of phy and disk at prereset(). If disk is already offline
> or phy is disabled, we return -ENOENT to libata to skip disk reset.
>
> As prereset() should be best-effort, we should continue to try disk reset
> beyond the situation we mentioned before.
>
> Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>
> Reviewed-by: John Garry <john.garry@...wei.com>
> ---
> drivers/scsi/libsas/sas_ata.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
The same as the first one, after fix the subject:
Reviewed-by: Jason Yan <yanaijie@...wei.com>
Powered by blists - more mailing lists