linux-kernel - Re: [PATCH v7 net-next] net: hyperv: dump TX indirection table to ethtool regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200723202251.vwh4xr7ogp72gcsg@lion.mk-sys.cz>
Date:   Thu, 23 Jul 2020 22:22:51 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Haiyang Zhang <haiyangz@...rosoft.com>
Cc:     Chi Song <Song.Chi@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 net-next] net: hyperv: dump TX indirection table to
 ethtool regs

On Thu, Jul 23, 2020 at 07:55:20PM +0000, Haiyang Zhang wrote:
> > -----Original Message-----
> > From: Michal Kubecek <mkubecek@...e.cz>
> > Sent: Thursday, July 23, 2020 3:36 PM
> > To: Chi Song <Song.Chi@...rosoft.com>
> > Cc: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> > <haiyangz@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
> > Wei Liu <wei.liu@...nel.org>; David S. Miller <davem@...emloft.net>; Jakub
> > Kicinski <kuba@...nel.org>; linux-hyperv@...r.kernel.org;
> > netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v7 net-next] net: hyperv: dump TX indirection table to
> > ethtool regs
> > 
> > On Wed, Jul 22, 2020 at 11:59:09PM -0700, Chi Song wrote:
> > > An imbalanced TX indirection table causes netvsc to have low
> > > performance. This table is created and managed during runtime. To help
> > > better diagnose performance issues caused by imbalanced tables, it needs
> > > make TX indirection tables visible.
> > >
> > > Because TX indirection table is driver specified information, so
> > > display it via ethtool register dump.
> > 
> > Is the Tx indirection table really unique to netvsc or can we expect
> > other drivers to support similar feature? Also, would it make sense to
> > allow also setting the table with ethtool? (AFAICS it can be only set
> > from hypervisor at the moment.)
> 
> Currently, TX indirection table is only used by the Hyper-V synthetic NIC. I'm 
> not aware of any other NIC planning to use this.
> This table is created by host dynamically based on host side CPU usage, 
> and provided to the VM periodically. Our protocol doesn't let the guest side 
> to change it.

If host is expected to rewrite the table periodically, it would indeed
be of little use to set it on guest side. OK, let's do it as register
dump and see if someone else comes with similar feature.

Michal