[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200723100634.GK3703480@smile.fi.intel.com>
Date: Thu, 23 Jul 2020 13:06:34 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc: Hoan Tran <hoan@...amperecomputing.com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Serge Semin <fancer.lancer@...il.com>,
Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
Rob Herring <robh+dt@...nel.org>, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] gpio: dwapb: Refactor GPIO resources initialization
On Thu, Jul 23, 2020 at 04:38:51AM +0300, Serge Semin wrote:
> This series is about the DW APB GPIO device initialization procedure
> cleaning up. First of all it has been discovered that having a
> vendor-specific "snps,nr-gpios" property isn't only redundant but also
> might be dangerous (see the commit log for details). Instead we suggest to
> use the generic "ngpios" property to define a number of GPIOs each DW APB
> GPIO controller port supports. Secondly seeing a tendency of the other
> GPIO drivers getting converted to using the GPIO-lib-based IRQ-chip
> interface this series provides a patch, which replaces the DW APB GPIO
> driver Generic IRQ-chip implementation with the GPIO-lib IRQ-chip one.
> Finally the DW APB GPIO device probe procedure is simplified by
> converting the code to be using the device managed resources for the
> reference clocks initialization, reset control assertion/de-assertion
> and GPIO-chip registration.
Thanks! For non-commented patches, excluding DT one,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
> Cc: Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
> Cc: Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: linux-gpio@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
>
> Serge Semin (7):
> dt-bindings: gpio: dwapb: Add ngpios property support
> gpio: dwapb: Add ngpios DT-property support
> gpio: dwapb: Move MFD-specific IRQ handler
> gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip
> gpio: dwapb: Get reset control by means of resource managed interface
> gpio: dwapb: Get clocks by means of resource managed interface
> gpio: dwapb: Use resource managed GPIO-chip add data method
>
> .../bindings/gpio/snps,dw-apb-gpio.yaml | 6 +
> drivers/gpio/Kconfig | 2 +-
> drivers/gpio/gpio-dwapb.c | 324 +++++++++---------
> 3 files changed, 161 insertions(+), 171 deletions(-)
>
> --
> 2.26.2
>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists