linux-kernel - Re: [PATCH] pinctrl: stm32: use the hwspin_lock_timeout_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbWUop6hyKM80zxaz85oQ8BfDLCtxBTzjOypnDpUm-a4Q@mail.gmail.com>
Date:   Thu, 23 Jul 2020 15:20:07 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Alexandre Torgue <alexandre.torgue@...com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH] pinctrl: stm32: use the hwspin_lock_timeout_in_atomic() API

On Mon, Jun 15, 2020 at 2:44 PM Alexandre Torgue
<alexandre.torgue@...com> wrote:

> From: Fabien Dessenne <fabien.dessenne@...com>
>
> Use the hwspin_lock_timeout_in_atomic() API which is the most appropriated
> here. Indeed:
> - hwspin_lock_() is called after spin_lock_irqsave()
> - the hwspin_lock_timeout() API relies on jiffies count which won't work
>   if IRQs are disabled which is the case here.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@...com>

Patch applied, sorry for missing this one.

Yours,
Linus Walleij