linux-kernel - Re: [PATCH] pinctrl: stm32: use the hwspin_lock_timeout_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f9648bd-6dcc-de70-a713-e889caf021ba@st.com>
Date:   Thu, 23 Jul 2020 16:02:32 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH] pinctrl: stm32: use the hwspin_lock_timeout_in_atomic()
 API



On 7/23/20 3:20 PM, Linus Walleij wrote:
> On Mon, Jun 15, 2020 at 2:44 PM Alexandre Torgue
> <alexandre.torgue@...com> wrote:
> 
>> From: Fabien Dessenne <fabien.dessenne@...com>
>>
>> Use the hwspin_lock_timeout_in_atomic() API which is the most appropriated
>> here. Indeed:
>> - hwspin_lock_() is called after spin_lock_irqsave()
>> - the hwspin_lock_timeout() API relies on jiffies count which won't work
>>    if IRQs are disabled which is the case here.
>>
>> Signed-off-by: Fabien Dessenne <fabien.dessenne@...com>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@...com>
> 
> Patch applied, sorry for missing this one.

No pb, thanks.

> 
> Yours,
> Linus Walleij
>