linux-kernel - Re: [PATCH V3] Softirq:avoid large sched delay from the pending softirqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d04mxs9t.fsf@nanos.tec.linutronix.de>
Date:   Thu, 23 Jul 2020 15:41:50 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     qianjun.kernel@...il.com, peterz@...radead.org, will@...nel.org,
        luto@...nel.org, urezki@...il.com, linux-kernel@...r.kernel.org
Cc:     laoar.shao@...il.com, jun qian <qianjun.kernel@...il.com>
Subject: Re: [PATCH V3] Softirq:avoid large sched delay from the pending softirqs

qianjun.kernel@...il.com writes:
> From: jun qian <qianjun.kernel@...il.com>
> +		/*
> +		 * the softirq's action has been running for too much time
> +		 * so it may need to wakeup the ksoftirqd
> +		 */
> +		if (need_resched() && ktime_get() > end)
> +			break;

As per my reply on V2 this is leaking non handled pending bits. If you
do a V4, can you please use sched_clock() instead of ktime_get()?

Thanks,

        tglx