linux-kernel - Re: [PATCH] dt-bindings: sound: convert Everest ES8316 binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58f31856-226b-41d5-deae-593e90d03598@katsuster.net>
Date:   Sat, 25 Jul 2020 00:50:33 +0900
From:   Katsuhiro Suzuki <katsuhiro@...suster.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: sound: convert Everest ES8316 binding to
 yaml

Hello Rob,

Thank you for review.

On 2020/07/24 6:26, Rob Herring wrote:
> On Thu, Jul 23, 2020 at 03:07:28AM +0900, Katsuhiro Suzuki wrote:
>> This patch converts Everest Semiconductor ES8316 low power audio
>> CODEC binding to DT schema.
>>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@...suster.net>
>> ---
>>   .../bindings/sound/everest,es8316.txt         | 23 ---------
>>   .../bindings/sound/everest,es8316.yaml        | 49 +++++++++++++++++++
>>   2 files changed, 49 insertions(+), 23 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.txt
>>   create mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/everest,es8316.txt b/Documentation/devicetree/bindings/sound/everest,es8316.txt
>> deleted file mode 100644
>> index 1bf03c5f2af4..000000000000
>> --- a/Documentation/devicetree/bindings/sound/everest,es8316.txt
>> +++ /dev/null
>> @@ -1,23 +0,0 @@
>> -Everest ES8316 audio CODEC
>> -
>> -This device supports both I2C and SPI.
>> -
>> -Required properties:
>> -
>> -  - compatible  : should be "everest,es8316"
>> -  - reg : the I2C address of the device for I2C
>> -
>> -Optional properties:
>> -
>> -  - clocks : a list of phandle, should contain entries for clock-names
>> -  - clock-names : should include as follows:
>> -         "mclk" : master clock (MCLK) of the device
>> -
>> -Example:
>> -
>> -es8316: codec@11 {
>> -	compatible = "everest,es8316";
>> -	reg = <0x11>;
>> -	clocks = <&clks 10>;
>> -	clock-names = "mclk";
>> -};
>> diff --git a/Documentation/devicetree/bindings/sound/everest,es8316.yaml b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
>> new file mode 100644
>> index 000000000000..b713404dac4f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
>> @@ -0,0 +1,49 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/everest,es8316.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Everest ES8316 audio CODEC
>> +
>> +maintainers:
>> +  - Mark Brown <broonie@...nel.org>
> 
> Should be someone who knows and cares about the h/w which is not Mark.
> 

OK, so set first committer Daniel and me (I can check codes on real device)
to maintainers.

Best Regards,
Katsuhiro Suzuki


>> +
>> +properties:
>> +  compatible:
>> +    const: everest,es8316
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    items:
>> +      - description: clock for master clock (MCLK)
>> +
>> +  clock-names:
>> +    items:
>> +      - const: mclk
>> +
>> +  "#sound-dai-cells":
>> +    const: 0
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - "#sound-dai-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c0 {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +      es8316: codec@11 {
>> +        compatible = "everest,es8316";
>> +        reg = <0x11>;
>> +        clocks = <&clks 10>;
>> +        clock-names = "mclk";
>> +        #sound-dai-cells = <0>;
>> +      };
>> +    };
>> -- 
>> 2.27.0
>>