linux-kernel - Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <IBDZDQ.K28R5FAI0BXI2@crapouillou.net>
Date:   Fri, 24 Jul 2020 17:50:06 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Harvey Hunt <harveyhuntnexus@...il.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to
 architecture only



Le ven. 24 juil. 2020 à 17:33, Krzysztof Kozlowski <krzk@...nel.org> a 
écrit :
> On Fri, 24 Jul 2020 at 17:19, Paul Cercueil <paul@...pouillou.net> 
> wrote:
>> 
>>  Hi Krzysztof,
>> 
>> 
>>  Le ven. 24 juil. 2020 à 16:54, Krzysztof Kozlowski 
>> <krzk@...nel.org> a
>>  écrit :
>>  > Enabling the MTD_NAND_JZ4780 driver makes sense only for specific
>>  > hardware - the Ingenic SoC architecture.  Set it's dependency to
>>  > MACH_INGENIC so it will not appear on unrelated architectures 
>> (easier
>>  > job for downstream/distro kernel engineers).
>> 
>>  Disagreed. It was done this way so that distro kernels can support
>>  multiple SoCs.
> 
> They will still be able to support multiple SoCs. Nothing changed
> here. The same we do for all ARM drivers (SoCs are multiplatform)...
> Unless you want to say that it is possible to support Ingenic SoC
> without MACH_INGENIC?

On MIPS, the SoC selection is a Kconfig "choice", so you can only 
support one SoC family, unfortunately. I'm the one to blame for using 
"depends on MIPS || COMPILE_TEST" on ingenic drivers, maybe it should 
depend on MACH_INGENIC indeed, but then it should be made possible to 
support more than one SoC family.

That's something that should be pointed out to the MIPS mailing list, I 
believe.

Btw: Does that mean you are the new maintainer for drivers/memory/?

Cheers,
-Paul

> Best regards,
> Krzysztof