[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200724155436.GA7460@kozik-lap>
Date: Fri, 24 Jul 2020 17:54:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Paul Cercueil <paul@...pouillou.net>
Cc: Harvey Hunt <harveyhuntnexus@...il.com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to
architecture only
On Fri, Jul 24, 2020 at 05:50:06PM +0200, Paul Cercueil wrote:
>
>
> Le ven. 24 juil. 2020 à 17:33, Krzysztof Kozlowski <krzk@...nel.org> a écrit
> :
> > On Fri, 24 Jul 2020 at 17:19, Paul Cercueil <paul@...pouillou.net>
> > wrote:
> > >
> > > Hi Krzysztof,
> > >
> > >
> > > Le ven. 24 juil. 2020 à 16:54, Krzysztof Kozlowski
> > > <krzk@...nel.org> a
> > > écrit :
> > > > Enabling the MTD_NAND_JZ4780 driver makes sense only for specific
> > > > hardware - the Ingenic SoC architecture. Set it's dependency to
> > > > MACH_INGENIC so it will not appear on unrelated architectures
> > > (easier
> > > > job for downstream/distro kernel engineers).
> > >
> > > Disagreed. It was done this way so that distro kernels can support
> > > multiple SoCs.
> >
> > They will still be able to support multiple SoCs. Nothing changed
> > here. The same we do for all ARM drivers (SoCs are multiplatform)...
> > Unless you want to say that it is possible to support Ingenic SoC
> > without MACH_INGENIC?
>
> On MIPS, the SoC selection is a Kconfig "choice", so you can only support
> one SoC family, unfortunately.
Let's say someone selected then some other architecture (MIPS_ALCHEMY).
They could select this MTD driver.
Does it mean they would be able to run it on Ingenic hardware?
> I'm the one to blame for using "depends on
> MIPS || COMPILE_TEST" on ingenic drivers, maybe it should depend on
> MACH_INGENIC indeed, but then it should be made possible to support more
> than one SoC family.
>
> That's something that should be pointed out to the MIPS mailing list, I
> believe.
Somehow JZ4780 entries in Maintainers do not mention MIPS list...
>
> Btw: Does that mean you are the new maintainer for drivers/memory/?
Yes, that's the coming change.
https://lore.kernel.org/lkml/20200724140345.GB13472@kozik-lap/T/#m91ca20920a7ec5f228a595f1816c15b6c85b6a09
Best regards,
Krzysztof
Powered by blists - more mailing lists