linux-kernel - Re: [PATCH 4/7] i2c: tegra: add high speed mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200725112648.GA26689@qmqm.qmqm.pl>
Date:   Sat, 25 Jul 2020 13:26:48 +0200
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Krishna Yarlagadda <kyarlagadda@...dia.com>
Cc:     digetx@...il.com, linux-i2c@...r.kernel.org,
        thierry.reding@...il.com, jonathanh@...dia.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldewangan@...dia.com, smohammed@...dia.com, rgumasta@...dia.com
Subject: Re: [PATCH 4/7] i2c: tegra: add high speed mode support

On Thu, Jul 23, 2020 at 05:48:50PM +0530, Krishna Yarlagadda wrote:
> From: Shardar Shariff Md <smohammed@...dia.com>
> 
> Add high speed mode support
[...]
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
[...]
> @@ -215,12 +218,14 @@ struct tegra_i2c_hw_feature {
>  	int clk_divisor_std_mode;
>  	int clk_divisor_fast_mode;
>  	u16 clk_divisor_fast_plus_mode;
> +	int clk_multiplier_hs_mode;
>  	bool has_multi_master_mode;
>  	bool has_slcg_override_reg;
>  	bool has_mst_fifo;
>  	const struct i2c_adapter_quirks *quirks;
>  	bool supports_bus_clear;
>  	bool has_reg_write_buffering;
> +	bool has_hs_mode_support;

This field seems redundant: == !clk_multiplier_hs_mode ?

Best Regards,
Michał Mirosław