linux-kernel - Re: [PATCH] sh: sh4: Fix reference count leak in sq_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <69b70f2a-c4c9-6dd2-95c7-5858873037b8@web.de>
Date:   Sat, 25 Jul 2020 13:27:56 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Yi Wang <wang.yi59@....com.cn>,
        Liao Pingfang <liao.pingfang@....com.cn>,
        linux-sh@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Rich Felker <dalias@...c.org>,
        Wang Liang <wang.liang82@....com.cn>,
        Xue Zhihong <xue.zhihong@....com.cn>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>
Subject: Re: [PATCH] sh: sh4: Fix reference count leak in sq_dev_add

> kobject_init_and_add() takes reference even when it fails. If this
> function returns an error, kobject_put() must be called to properly
> clean up the memory associated with the object.

* An imperative wording can be preferred for the change description,
  can't it?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus