[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200726114224.1825a769@coco.lan>
Date: Sun, 26 Jul 2020 11:42:24 +0200
From: Mauro Carvalho Chehab <mchehab@...nel.org>
To: Rohit K Bharadwaj <bharadwaj.rohit8@...il.com>
Cc: sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org,
linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace
Em Sun, 26 Jul 2020 14:35:12 +0530
Rohit K Bharadwaj <bharadwaj.rohit8@...il.com> escreveu:
> this patch fixes style of open brace after functions and if statements
>
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@...il.com>
> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi,
> blob = (const unsigned char *)fw + bi->blob.offset;
>
> /* sanity check */
> - if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + bi->blob.data_size + bi->blob.padding_size)
> - {
> + if (bi->blob.size !=
> + bi->blob.text_size + bi->blob.icache_size +
> + bi->blob.data_size + bi->blob.padding_size) {
Please adjust the alignments here. I'm pretty sure checkpatch --strict
will end complaining with the above, as the first line ends with "=".
I would, instead, code it as:
if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size +
bi->blob.data_size + bi->blob.padding_size) {
Thanks,
Mauro
Powered by blists - more mailing lists