lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Jul 2020 15:26:56 +0530 From: Rohit K Bharadwaj <bharadwaj.rohit8@...il.com> To: Mauro Carvalho Chehab <mchehab@...nel.org> Cc: sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, linux-media@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace On 26/07/20 3:12 pm, Mauro Carvalho Chehab wrote: > Em Sun, 26 Jul 2020 14:35:12 +0530 > Rohit K Bharadwaj <bharadwaj.rohit8@...il.com> escreveu: > >> this patch fixes style of open brace after functions and if statements >> >> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@...il.com> > >> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, >> blob = (const unsigned char *)fw + bi->blob.offset; >> >> /* sanity check */ >> - if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + bi->blob.data_size + bi->blob.padding_size) >> - { >> + if (bi->blob.size != >> + bi->blob.text_size + bi->blob.icache_size + >> + bi->blob.data_size + bi->blob.padding_size) { > > > Please adjust the alignments here. I'm pretty sure checkpatch --strict > will end complaining with the above, as the first line ends with "=". > > I would, instead, code it as: > > if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + > bi->blob.data_size + bi->blob.padding_size) { > > > Thanks, > Mauro > sure sir, do I have to make a v4 of the patch and send all the patches in this series again or should I just send this one particular patch again?
Powered by blists - more mailing lists