linux-kernel - [tip:WIP.core/entry 1/1] arch/riscv/kernel/ptrace.c:162:6: error: too few arguments to function 'secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 07:41:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: [tip:WIP.core/entry 1/1] arch/riscv/kernel/ptrace.c:162:6: error:
 too few arguments to function 'secure_computing'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.core/entry
head:   85546baab915492f05f29b91c4003bf15891e89b
commit: 85546baab915492f05f29b91c4003bf15891e89b [1/1] entry: Fix !CONFIG_SECCOMP stub
config: riscv-allnoconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 85546baab915492f05f29b91c4003bf15891e89b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/riscv/kernel/ptrace.c:151:15: warning: no previous prototype for 'do_syscall_trace_enter' [-Wmissing-prototypes]
     151 | __visible int do_syscall_trace_enter(struct pt_regs *regs)
         |               ^~~~~~~~~~~~~~~~~~~~~~
   arch/riscv/kernel/ptrace.c: In function 'do_syscall_trace_enter':
>> arch/riscv/kernel/ptrace.c:162:6: error: too few arguments to function 'secure_computing'
     162 |  if (secure_computing() == -1)
         |      ^~~~~~~~~~~~~~~~
   In file included from include/linux/sched.h:21,
                    from arch/riscv/include/asm/syscall.h:14,
                    from arch/riscv/kernel/ptrace.c:11:
   include/linux/seccomp.h:64:19: note: declared here
      64 | static inline int secure_computing(const struct seccomp_data *sd) { return 0; }
         |                   ^~~~~~~~~~~~~~~~
   arch/riscv/kernel/ptrace.c: At top level:
   arch/riscv/kernel/ptrace.c:174:16: warning: no previous prototype for 'do_syscall_trace_exit' [-Wmissing-prototypes]
     174 | __visible void do_syscall_trace_exit(struct pt_regs *regs)
         |                ^~~~~~~~~~~~~~~~~~~~~

vim +/secure_computing +162 arch/riscv/kernel/ptrace.c

e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  146  
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  147  /*
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  148   * Allows PTRACE_SYSCALL to work.  These are called from entry.S in
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  149   * {handle,ret_from}_syscall.
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  150   */
af33d2433b03d6 Tycho Andersen      2020-02-08  151  __visible int do_syscall_trace_enter(struct pt_regs *regs)
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  152  {
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  153  	if (test_thread_flag(TIF_SYSCALL_TRACE))
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  154  		if (tracehook_report_syscall_entry(regs))
af33d2433b03d6 Tycho Andersen      2020-02-08  155  			return -1;
e2c0cdfba7f699 Palmer Dabbelt      2017-07-10  156  
5340627e3fe080 David Abdurachmanov 2019-10-04  157  	/*
5340627e3fe080 David Abdurachmanov 2019-10-04  158  	 * Do the secure computing after ptrace; failures should be fast.
5340627e3fe080 David Abdurachmanov 2019-10-04  159  	 * If this fails we might have return value in a0 from seccomp
5340627e3fe080 David Abdurachmanov 2019-10-04  160  	 * (via SECCOMP_RET_ERRNO/TRACE).
5340627e3fe080 David Abdurachmanov 2019-10-04  161  	 */
af33d2433b03d6 Tycho Andersen      2020-02-08 @162  	if (secure_computing() == -1)
af33d2433b03d6 Tycho Andersen      2020-02-08  163  		return -1;
5340627e3fe080 David Abdurachmanov 2019-10-04  164  

:::::: The code at line 162 was first introduced by commit
:::::: af33d2433b03d63ed31fcfda842f46676a5e1afc riscv: fix seccomp reject syscall code path

:::::: TO: Tycho Andersen <tycho@...ho.ws>
:::::: CC: Palmer Dabbelt <palmerdabbelt@...gle.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (5369 bytes)