linux-kernel - Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jul 2020 18:33:45 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Vadym Kochan <vadym.kochan@...ision.eu>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Andrew Lunn <andrew@...n.ch>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Andrii Savka <andrii.savka@...ision.eu>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mickey Rachamim <mickeyr@...vell.com>
Subject: Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

On Mon, Jul 27, 2020 at 5:11 PM Jiri Pirko <jiri@...nulli.us> wrote:
> Mon, Jul 27, 2020 at 03:29:17PM CEST, andy.shevchenko@...il.com wrote:
> >On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan <vadym.kochan@...ision.eu> wrote:

...

> >> +err_prestera_dev_register:
> >> +       free_irq(pci_irq_vector(pdev, 0), fw);
> >> +err_request_irq:
> >> +       pci_free_irq_vectors(pdev);
> >> +err_irq_alloc:
> >> +       destroy_workqueue(fw->wq);
> >> +err_wq_alloc:
> >> +       prestera_fw_uninit(fw);
> >
> >> +err_prestera_fw_init:
> >> +err_pci_dev_alloc:
> >> +err_dma_mask:
> >
> >All three are useless.
>
> This is okay. It is symmetrical with init. err_what_you_init. It is all
> over the place.

We use multi-point return and these are inconsistent with the
approach. They simple LOCs without value.

-- 
With Best Regards,
Andy Shevchenko