[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200727.123230.568578775098761493.davem@davemloft.net>
Date: Mon, 27 Jul 2020 12:32:30 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: vadym.kochan@...ision.eu
Cc: kuba@...nel.org, jiri@...lanox.com, idosch@...lanox.com,
andrew@...n.ch, oleksandr.mazur@...ision.eu,
serhiy.boiko@...ision.eu, serhiy.pshyk@...ision.eu,
volodymyr.mytnyk@...ision.eu, taras.chornyi@...ision.eu,
andrii.savka@...ision.eu, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, andy.shevchenko@...il.com,
mickeyr@...vell.com
Subject: Re: [net-next v4 1/6] net: marvell: prestera: Add driver for
Prestera family ASIC devices
From: Vadym Kochan <vadym.kochan@...ision.eu>
Date: Mon, 27 Jul 2020 15:22:37 +0300
> + /* called by device driver to pass event up to the higher layer */
> + int (*recv_msg)(struct prestera_device *dev, u8 *msg, size_t size);
> +
> + /* called by higher layer to send request to the firmware */
> + int (*send_req)(struct prestera_device *dev, u8 *in_msg,
> + size_t in_size, u8 *out_msg, size_t out_size,
> + unsigned int wait);
If you type "msg", "in_msg", and "out_msg" as (void *) you can remove
a lot of unnecessary casts in this driver.
Thank you.
Powered by blists - more mailing lists