linux-kernel - Re: [PATCH v5 08/10] net: eth: altera: add support for ptp and timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200727085452.412f7031@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 27 Jul 2020 08:54:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Ooi, Joyce" <joyce.ooi@...el.com>
Cc:     Thor Thayer <thor.thayer@...ux.intel.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Dalon Westergreen <dalon.westergreen@...ux.intel.com>,
        Tan Ley Foon <ley.foon.tan@...el.com>,
        See Chin Liang <chin.liang.see@...el.com>,
        Dinh Nguyen <dinh.nguyen@...el.com>,
        Dalon Westergreen <dalon.westergreen@...el.com>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH v5 08/10] net: eth: altera: add support for ptp and
 timestamping

On Mon, 27 Jul 2020 17:21:55 +0800 Ooi, Joyce wrote:
> From: Dalon Westergreen <dalon.westergreen@...el.com>
> 
> Add support for the ptp clock used with the tse, and update
> the driver to support timestamping when enabled.  We also
> enable debugfs entries for the ptp clock to allow some user
> control and interaction with the ptp clock.
> 
> Cc: Richard Cochran <richardcochran@...il.com>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@...el.com>
> Signed-off-by: Joyce Ooi <joyce.ooi@...el.com>

W=1 build reveals a warnings, please fix:

drivers/net/ethernet/altera/intel_fpga_tod.c:334:55: warning: Using plain integer as NULL 
pointer