linux-kernel - Re: [PATCH] qed: fix assignment of n_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200727.124652.1347094721322555381.davem@davemloft.net>
Date:   Mon, 27 Jul 2020 12:46:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jgg@...dia.com
Cc:     colin.king@...onical.com, mkalderon@...vell.com,
        aelior@...vell.com, dledford@...hat.com, irusskikh@...vell.com,
        alobakin@...vell.com, linux-rdma@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params
 field

From: Jason Gunthorpe <jgg@...dia.com>
Date: Mon, 27 Jul 2020 13:17:39 -0300

> On Mon, Jul 27, 2020 at 03:17:12PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>> 
>> Currently n_rq_elems is being assigned to params.elem_size instead of the
>> field params.num_elems.  Coverity is detecting this as a double assingment
>> to params.elem_size and reporting this as an usused value on the first
>> assignment.  Fix this.
>> 
>> Addresses-Coverity: ("Unused value")
>> Fixes: b6db3f71c976 ("qed: simplify chain allocation with init params struct")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  drivers/infiniband/hw/qedr/verbs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> DaveM will need to take this since the Fixed patch is in his tree,
> thanks.

Applied to net-next, thanks everyone.