linux-kernel - Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200727.124942.1829978531845134184.davem@davemloft.net>
Date:   Mon, 27 Jul 2020 12:49:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wenhu.wang@...o.com
Cc:     elder@...nel.org, kuba@...nel.org, kvalo@...eaurora.org,
        agross@...nel.org, bjorn.andersson@...aro.org, ohad@...ery.com,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, alsa-devel@...a-project.org,
        ath11k@...ts.infradead.org, netdev@...r.kernel.org,
        ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        srinivas.kandagatla@...aro.org, sibis@...eaurora.org
Subject: Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

From: 王文虎 <wenhu.wang@...o.com>
Date: Mon, 27 Jul 2020 23:03:16 +0800 (GMT+08:00)

> Currently the qmi_handle is initialized single threaded and strictly
> ordered with the active set to 1. This is pretty simple and safe but
> sometimes ineffency. So it is better to allow user to decide whether
> a high priority workqueue should be used.
> 
> Signed-off-by: Wang Wenhu <wenhu.wang@...o.com>

Every caller sets the new value to "0", so you should submit this when
you have a cast that actually sets it to "1".

Also, the new argument should be "bool" instead of "unsigned int" and
use "true" and "false" in the callers.

Thank you.