linux-kernel - Re: [PATCH] [net/ipv6] ip6_output: Add ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpW+Z=y6myMRfkmKuqQpVTLD52vpTB41esJc5zRFW4DK2w@mail.gmail.com>
Date:   Mon, 27 Jul 2020 12:50:29 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Gaurav Singh <gaurav1086@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "open list:NETWORKING [IPv4/IPv6]" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [net/ipv6] ip6_output: Add ipv6_pinfo null check

On Sun, Jul 26, 2020 at 8:39 PM Gaurav Singh <gaurav1086@...il.com> wrote:
>
> ipv6_pinfo is initlialized by inet6_sk() which returns NULL.

Why? It only returns NULL for timewait or request sock, but
I don't see how ip6_autoflowlabel() could be called on these
sockets. So please explain.

> Hence it can cause segmentation fault. Fix this by adding a
> NULL check.

Which exact call path? Do you have a full stack trace?

Thanks.