linux-kernel - Re: [PATCH v1] driver core: Change delimiter in devlink device's name to "--"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGETcx8FoSVwneZNEAeqpAfs8OkeMzbCBWYMSkJbQYE5DLHing@mail.gmail.com>
Date:   Mon, 27 Jul 2020 15:09:22 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Cc: Android Kernel" <kernel-team@...roid.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] driver core: Change delimiter in devlink device's name
 to "--"

On Mon, Jul 27, 2020 at 7:21 AM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Fri, Jul 24, 2020 at 8:05 PM Saravana Kannan <saravanak@...gle.com> wrote:
> >
> > The devlink device name is of the form "supplier:consumer". But ":" is
> > fairly common in device names and makes it visually hard to distinguish
> > supplier and consumer. So, replace it with "--" to make it easier.
> >
> > Signed-off-by: Saravana Kannan <saravanak@...gle.com>
>
> Well, this makes sense in principle, but I wonder how much risk of
> breaking anything in user space there is?

The original patch got in only a week or two before this patch. So I
don't think there's any real risk of breaking user space here. Also,
it hasn't been part of any kernel release version yet. So I think we
are safe.

Also, Greg already took it.

-Saravana