linux-kernel - Re: [PATCH v1] driver core: Change delimiter in devlink device's name to "--"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0izVrJeQNroeNS8xu66c8LskHSiCJRQvVvrhWSZV8tL_g@mail.gmail.com>
Date:   Mon, 27 Jul 2020 16:21:05 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Cc: Android Kernel" <kernel-team@...roid.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] driver core: Change delimiter in devlink device's name
 to "--"

On Fri, Jul 24, 2020 at 8:05 PM Saravana Kannan <saravanak@...gle.com> wrote:
>
> The devlink device name is of the form "supplier:consumer". But ":" is
> fairly common in device names and makes it visually hard to distinguish
> supplier and consumer. So, replace it with "--" to make it easier.
>
> Signed-off-by: Saravana Kannan <saravanak@...gle.com>

Well, this makes sense in principle, but I wonder how much risk of
breaking anything in user space there is?

> ---
>  Documentation/ABI/testing/sysfs-class-devlink | 2 +-
>  drivers/base/core.c                           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-devlink b/Documentation/ABI/testing/sysfs-class-devlink
> index 3a24973abb83..64791b65c9a3 100644
> --- a/Documentation/ABI/testing/sysfs-class-devlink
> +++ b/Documentation/ABI/testing/sysfs-class-devlink
> @@ -4,7 +4,7 @@ Contact:        Saravana Kannan <saravanak@...gle.com>
>  Description:
>                 Provide a place in sysfs for the device link objects in the
>                 kernel at any given time.  The name of a device link directory,
> -               denoted as ... above, is of the form <supplier>:<consumer>
> +               denoted as ... above, is of the form <supplier>--<consumer>
>                 where <supplier> is the supplier device name and <consumer> is
>                 the consumer device name.
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index b6e8b0bb76e4..4d05868d9356 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -623,7 +623,7 @@ struct device_link *device_link_add(struct device *consumer,
>
>         link->link_dev.class = &devlink_class;
>         device_set_pm_not_required(&link->link_dev);
> -       dev_set_name(&link->link_dev, "%s:%s",
> +       dev_set_name(&link->link_dev, "%s--%s",
>                      dev_name(supplier), dev_name(consumer));
>         if (device_register(&link->link_dev)) {
>                 put_device(consumer);
> --
> 2.28.0.rc0.142.g3c755180ce-goog
>