[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200727131742.82289-1-vaibhavgupta40@gmail.com>
Date: Mon, 27 Jul 2020 18:47:43 +0530
From: Vaibhav Gupta <vaibhavgupta40@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>,
Bjorn Helgaas <helgaas@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Bjorn Helgaas <bjorn@...gaas.com>,
Vaibhav Gupta <vaibhav.varodek@...il.com>,
Mark Brown <broonie@...nel.org>
Cc: Vaibhav Gupta <vaibhavgupta40@...il.com>,
linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kernel-mentees@...ts.linuxfoundation.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable
Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)
This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.
Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management")
Reported by: Andy Shevchenko <andy.shevchenko@...il.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>
---
drivers/spi/spi-topcliff-pch.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 281a90f1b5d8..c73a03ddf5f3 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1648,8 +1648,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)
dev_dbg(dev, "%s ENTRY\n", __func__);
- device_wakeup_disable(dev);
-
/* set suspend status to false */
pd_dev_save->board_dat->suspend_sts = false;
--
2.27.0
Powered by blists - more mailing lists