linux-kernel - Re: [PATCH] media: usbvision: fixed coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200728155311.GA4178776@kroah.com>
Date:   Tue, 28 Jul 2020 17:53:11 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dhiraj Sharma <dhiraj.sharma0024@...il.com>
Cc:     devel@...verdev.osuosl.org, arnd@...db.de,
        linux-kernel@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>,
        stern@...land.harvard.edu, jrdr.linux@...il.com,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] media: usbvision: fixed coding style

On Tue, Jul 28, 2020 at 09:14:24PM +0530, Dhiraj Sharma wrote:
> Sorry, I didn't realize that I committed a mistake by not replying to
> all. It was an accidental mistake which will not be committed in
> future now.
> 
> >
> > That is not needed in a changelog text.
> >
> 
> Alright Sir.
> 
> > Neither is this, please be specific about what you have fixed.  My bot
> > should kick in soon with more specifics...
> 
> Sir there were checkpatch.pl styling issues and I fixed them all
> together, so should I write a proper changelog as what all I fixed i.e
> errors and warnings thrown by checkpatch.pl

As the bot said, only do one type of thing per patch, and "fix all
checkpatch errors/warnings" is not one type of thing.